fuel-wizard/fuel-wizard
2
2
Fork 0
Code Issues 1 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Feat 1: Add support for fly to point on row selection (on map page with station selector) #2

Merged
kurt-mcrae merged 9 commits from feat/1/map-focus-station-select into master 2025-05-03 17:10:20 +10:00
Conversation 7 Commits 9 Files Changed 13
+7965 -471
MaxWroe commented 2025-05-03 13:56:02 +10:00
Collaborator
Copy Link
Copy Source

Inclusions:

  • Fly to fuel station marker on map selection in side bar from map window
Inclusions: - Fly to fuel station marker on map selection in side bar from map window
MaxWroe added 2 commits 2025-05-03 13:56:02 +10:00
Add support for fly to point on row selection (on map page with station selector) 2109fecad4
Revert changes to .env b86659b86f
MaxWroe requested review from kurt-mcrae 2025-05-03 13:56:07 +10:00
MaxWroe commented 2025-05-03 13:56:38 +10:00
Author
Collaborator
Copy Link
Copy Source

There is zero chance that refactor of the CustomMap is going to break anything trust me bro

There is zero chance that refactor of the CustomMap is going to break anything trust me bro
😆 1 🚀 1
kurt-mcrae commented 2025-05-03 16:25:37 +10:00
Owner
Copy Link
Copy Source

There is zero chance that refactor of the CustomMap is going to break anything trust me bro

If only there was some way to test software!

> There is zero chance that refactor of the CustomMap is going to break anything trust me bro If only there was some way to test software!
kurt-mcrae commented 2025-05-03 16:35:17 +10:00
Owner
Copy Link
Copy Source

@MaxWroe — Just pulled and ran it; works well! This page feels much more natural from a UX perspective now. Couple of small things I want to adjust in the PR, I'll just go ahead and make the changes on this branch so we can get this merged up.
Thanks for being the first contributor!

@MaxWroe — Just pulled and ran it; works well! This page feels much more natural from a UX perspective now. Couple of small things I want to adjust in the PR, I'll just go ahead and make the changes on this branch so we can get this merged up. Thanks for being the first contributor!
kurt-mcrae reviewed 2025-05-03 16:36:03 +10:00
frontend/.env.development Outdated
@@ -1,3 +1,3 @@
DEPLOYMENT_ENVIRONMENT=development
NEXT_PUBLIC_API_BASE_URL=http://localhost:5161
kurt-mcrae commented 2025-05-03 16:36:03 +10:00
Owner
Copy Link
Copy Source

I will revert this back, as it's the development .env file.

I will revert this back, as it's the development `.env` file.
kurt-mcrae reviewed 2025-05-03 16:37:20 +10:00
frontend/app/components/map/ControlledMarker.tsx Outdated
@@ -0,0 +3,4 @@
import { Marker as LeafletMarker } from "leaflet";
export const ControlledMarker = (props: MarkerProps & { forceOpen?: boolean }) => {
const leafletRef = useRef<LeafletMarker | null>(null);
kurt-mcrae commented 2025-05-03 16:37:20 +10:00
Owner
Copy Link
Copy Source

Glad you found the patience to start pulling some of this map stuff out of the mega file 😆

Glad you found the patience to start pulling some of this map stuff out of the mega file 😆
kurt-mcrae reviewed 2025-05-03 17:04:24 +10:00
fuel-wizard.sln Outdated
@@ -0,0 +1,24 @@
Microsoft Visual Studio Solution File, Format Version 12.00
kurt-mcrae commented 2025-05-03 17:04:24 +10:00
Owner
Copy Link
Copy Source

Now this, I cannot abide 😢

Now **this**, I cannot abide 😢
kurt-mcrae added 6 commits 2025-05-03 17:05:22 +10:00
Revert dev env vars ec00b4aa12
Update dependencies 20ed186455
Cleanup, format, annotate types 7ebc633755
Fixing lint errors 30a7637670
Format bee2663099
Format, cleanup 4525bc6cf5
kurt-mcrae added 1 commit 2025-05-03 17:08:38 +10:00
Delete fuel-wizard.sln 6cb29f949a
kurt-mcrae approved these changes 2025-05-03 17:09:51 +10:00
kurt-mcrae left a comment
Owner
Copy Link
Copy Source

lgtm

lgtm
kurt-mcrae merged commit c623b8431c into master 2025-05-03 17:10:20 +10:00
Sign in to join this conversation.
Reviewers
No Reviewers
kurt-mcrae
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes kurt-mcrae renovate-bot (Renovate Bot)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fuel-wizard/fuel-wizard#2