Feat 1: Add support for fly to point on row selection (on map page with station selector) #2

Merged
kurt-mcrae merged 9 commits from feat/1/map-focus-station-select into master 2025-05-03 17:10:20 +10:00
Collaborator

Inclusions:

  • Fly to fuel station marker on map selection in side bar from map window
Inclusions: - Fly to fuel station marker on map selection in side bar from map window
MaxWroe added 2 commits 2025-05-03 13:56:02 +10:00
MaxWroe requested review from kurt-mcrae 2025-05-03 13:56:07 +10:00
Author
Collaborator

There is zero chance that refactor of the CustomMap is going to break anything trust me bro

There is zero chance that refactor of the CustomMap is going to break anything trust me bro
Owner

There is zero chance that refactor of the CustomMap is going to break anything trust me bro

If only there was some way to test software!

> There is zero chance that refactor of the CustomMap is going to break anything trust me bro If only there was some way to test software!
Owner

@MaxWroe — Just pulled and ran it; works well! This page feels much more natural from a UX perspective now. Couple of small things I want to adjust in the PR, I'll just go ahead and make the changes on this branch so we can get this merged up.
Thanks for being the first contributor!

@MaxWroe — Just pulled and ran it; works well! This page feels much more natural from a UX perspective now. Couple of small things I want to adjust in the PR, I'll just go ahead and make the changes on this branch so we can get this merged up. Thanks for being the first contributor!
kurt-mcrae reviewed 2025-05-03 16:36:03 +10:00
@@ -1,3 +1,3 @@
DEPLOYMENT_ENVIRONMENT=development
NEXT_PUBLIC_API_BASE_URL=http://localhost:5161
Owner

I will revert this back, as it's the development .env file.

I will revert this back, as it's the development `.env` file.
kurt-mcrae reviewed 2025-05-03 16:37:20 +10:00
@@ -0,0 +3,4 @@
import { Marker as LeafletMarker } from "leaflet";
export const ControlledMarker = (props: MarkerProps & { forceOpen?: boolean }) => {
const leafletRef = useRef<LeafletMarker | null>(null);
Owner

Glad you found the patience to start pulling some of this map stuff out of the mega file 😆

Glad you found the patience to start pulling some of this map stuff out of the mega file 😆
kurt-mcrae reviewed 2025-05-03 17:04:24 +10:00
fuel-wizard.sln Outdated
@@ -0,0 +1,24 @@
Microsoft Visual Studio Solution File, Format Version 12.00
Owner

Now this, I cannot abide 😢

Now **this**, I cannot abide 😢
kurt-mcrae added 6 commits 2025-05-03 17:05:22 +10:00
kurt-mcrae added 1 commit 2025-05-03 17:08:38 +10:00
kurt-mcrae approved these changes 2025-05-03 17:09:51 +10:00
kurt-mcrae left a comment
Owner

lgtm

lgtm
kurt-mcrae merged commit c623b8431c into master 2025-05-03 17:10:20 +10:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fuel-wizard/fuel-wizard#2